Capture warnings during collect DAGs #39109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
force-pushed
the
capture-warnings-dagbag
branch
from
43bfd93 to
62c9804
Compare
Member
|
Should not we also re-raise warnings in this case? What happens if someone relies on those warnings raised? |
Contributor
Author
|
Good point, I will add explicit re-raise in case if it found warnings |
potiuk
approved these changes
Apr 18, 2024
vincbeck
approved these changes
Apr 18, 2024
uranusjr
reviewed
Apr 19, 2024
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
dirrao
approved these changes
Apr 20, 2024
eladkal
approved these changes
Apr 21, 2024
utkarsharma2
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base implementation for capture warnings during collect DAGs during filling DAG bag.
This information not always printed into the logs or it hard to find and depends on the deployments settings.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.