add dns_config and diagnostics parameters to AzureContainerInstancesOperator #39156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39149
When creating a container using the AzureContainerInstanceOperator, it would be good to be able to pass a specific dns configuration and log analytics workspace. These are already supported by the azure management api.
Non-breaking change that adds some nice extra functionality. In some cases, providing an explicit dns config is required for private containers when existing VNet DNS is not picked up. (see https://stackoverflow.com/questions/64700687/how-to-get-azure-container-instances-using-my-dns-server). Adding the ability to send logs to an existing log analytics workspace is a nice quality of life addition for sending non-airflow, application specific logs.
Happy to add more tests if required.