Skip to content

Conversation

@jgao54
Copy link

@jgao54 jgao54 commented Sep 18, 2018

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Currently due to a change in method name, none of the roles beside Admin is capable of viewing logs in Airflow. Log viewing should be part of of the default rbac configuration for all roles (except public).

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Tested via UI

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov-io
Copy link

Codecov Report

Merging #3916 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3916      +/-   ##
==========================================
- Coverage   77.55%   77.53%   -0.02%     
==========================================
  Files         198      198              
  Lines       15847    15847              
==========================================
- Hits        12290    12287       -3     
- Misses       3557     3560       +3
Impacted Files Coverage Δ
airflow/www_rbac/security.py 91.27% <ø> (ø) ⬆️
airflow/jobs.py 82.48% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f50083...16d3c23. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #3916 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3916      +/-   ##
==========================================
- Coverage   77.55%   77.53%   -0.02%     
==========================================
  Files         198      198              
  Lines       15847    15847              
==========================================
- Hits        12290    12287       -3     
- Misses       3557     3560       +3
Impacted Files Coverage Δ
airflow/www_rbac/security.py 91.27% <ø> (ø) ⬆️
airflow/jobs.py 82.48% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f50083...16d3c23. Read the comment docs.

@criccomini
Copy link
Contributor

LGTM!

@jgao54
Copy link
Author

jgao54 commented Sep 19, 2018

Closing because it's a dupe of #3913

@jgao54 jgao54 closed this Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants