Skip to content

Conversation

@moiseenkov
Copy link
Contributor

  1. fixed BigQueryToMsSqlOperator - from now on it provides a correct parameter to the MsSqlHook (mssql_conn_id instead of mysql_conn_id);
  2. added unit tests;
  3. adjusted system test so it actually performs data transfer.

@boring-cyborg boring-cyborg bot added area:providers area:system-tests provider:google Google (including GCP) related issues labels Apr 22, 2024
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moiseenkov moiseenkov force-pushed the bigquery_to_mssql_fix_typo branch from 14df23b to 4080d96 Compare April 23, 2024 08:09
@potiuk
Copy link
Member

potiuk commented Apr 23, 2024

One tes to fix

@moiseenkov moiseenkov force-pushed the bigquery_to_mssql_fix_typo branch from 4080d96 to c9b2a19 Compare April 23, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers area:system-tests provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants