Fix DataprocSubmitJobOperator in deferrable mode=True when task is marked as failed. #39230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
pankajkoti
reviewed
Apr 24, 2024
sunank200
force-pushed
the
dataproc_submit_job_on_kill
branch
from
54196de to
d9b2f65
Compare
pankajkoti
approved these changes
Apr 24, 2024
sunank200
force-pushed
the
dataproc_submit_job_on_kill
branch
from
d9b2f65 to
39d5f71
Compare
pankajastro
reviewed
Apr 25, 2024
sunank200
force-pushed
the
dataproc_submit_job_on_kill
branch
from
39d5f71 to
ab7e923
Compare
Lee-W
reviewed
Apr 25, 2024
sunank200
force-pushed
the
dataproc_submit_job_on_kill
branch
from
6558fa7 to
59a1d73
Compare
vatsrahul1001
approved these changes
Apr 26, 2024
sunank200
force-pushed
the
dataproc_submit_job_on_kill
branch
from
59a1d73 to
fc6f54d
Compare
Lee-W
reviewed
Apr 26, 2024
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
Overall, it looks good to me. Left one minor discussion.
Member
|
We will need to improvise here based on #36090 (comment) |
2 tasks
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user cancels a task for
DataprocSubmitJobOperatorin deferrable mode, the job should be cancelled in the same way as non-deferrable mode. This PR intends to fix this behaviour.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.