openlineage: use ProcessPoolExecutor over ThreadPoolExecutor.
#39235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Taragolis
reviewed
Apr 25, 2024
JDarDagran
force-pushed
the
openlineage/use-process-pool-executor
branch
from
e8edb6a to
582d9b1
Compare
JDarDagran
force-pushed
the
openlineage/use-process-pool-executor
branch
2 times, most recently
from
7670638 to
05261ed
Compare
Contributor
Author
|
Needed a bit more time to confirm in various environment that Converting to ready for review since I've added configurable |
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> Make `max_workers` configurable. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
openlineage/use-process-pool-executor
branch
from
05261ed to
b9bb056
Compare
Contributor
|
Internal tests did not find any problems when this approach is enabled. |
mobuchowski
approved these changes
May 14, 2024
tatiana
approved these changes
May 14, 2024
Contributor
tatiana
left a comment
tatiana
left a comment
There was a problem hiding this comment.
Thanks for working on this, @JDarDagran , @rahul342 confirmed things worked with our internal benchmarks - it will be great to see this change reaching Airflow + OL users.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Make `max_workers` configurable. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may possibly fix #39232. I tested the solution many times locally and deployed in Astro Cloud (so it gives me quite certainty it works).
I don't really know how to write tests for the change (load test is the thing but do we do this in regular tests?). Some guidance would be very much helpful.