Fix side effects in AWS Batch Executor test #39474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasted a lot of my hours in debugging failures for apache#39450 This was modifying a global env vars and causing side effects in other tests
boring-cyborg
bot
added
area:providers
provider:amazon
Lee-W
approved these changes
May 8, 2024
Taragolis
approved these changes
May 8, 2024
pankajkoti
approved these changes
May 8, 2024
pateash
pushed a commit
to pateash/airflow
that referenced
this pull request
May 13, 2024
This wasted a lot of my hours in debugging failures for apache#39450 This was modifying a global env vars and causing side effects in other tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasted a lot of my hours in debugging failures for #39450
This was modifying global env vars and causing side effects in other tests
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.