Skip to content

[AIRFLOW-XXX] Don't spam test logs with "bad cron expression" messages #3973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Sep 29, 2018
Merged

[AIRFLOW-XXX] Don't spam test logs with "bad cron expression" messages #3973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/dags/.airflowignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.*_invalid.*
18 changes: 12 additions & 6 deletions tests/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3285,16 +3285,22 @@ def test_list_py_file_paths(self):
[JIRA-1357] Test the 'list_py_file_paths' function used by the
scheduler to list and load DAGs.
"""
detected_files = []
expected_files = []
detected_files = set()
expected_files = set()
# No_dags is empty, _invalid_ is ignored by .airflowignore
ignored_files = [
'no_dags.py',
'test_invalid_cron.py',
'test_zip_invalid_cron.zip',
]
for file_name in os.listdir(TEST_DAGS_FOLDER):
if file_name.endswith('.py') or file_name.endswith('.zip'):
if file_name not in ['no_dags.py']:
expected_files.append(
if file_name not in ignored_files:
expected_files.add(
'{}/{}'.format(TEST_DAGS_FOLDER, file_name))
for file_path in list_py_file_paths(TEST_DAGS_FOLDER):
detected_files.append(file_path)
self.assertEqual(sorted(detected_files), sorted(expected_files))
detected_files.add(file_path)
self.assertEqual(detected_files, expected_files)

def test_reset_orphaned_tasks_nothing(self):
"""Try with nothing. """
Expand Down