Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented May 21, 2024

We have broken main due to new version of requests

=========================== short test summary info ============================
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_basic_docker_operator - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_basic_docker_operator_with_param - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_basic_docker_operator_multiple_output - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_no_return - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_skip_docker_operator[kwargs0-0-success] - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_skip_docker_operator[kwargs3-0-success] - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_skip_docker_operator[kwargs6-0-success] - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_skip_docker_operator[kwargs7-100-skipped] - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_skip_docker_operator[kwargs9-0-skipped] - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_skip_docker_operator[kwargs10-0-success] - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_skip_docker_operator[kwargs11-100-skipped] - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_skip_docker_operator[kwargs14-0-success] - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
FAILED tests/providers/docker/decorators/test_docker.py::TestDockerDecorator::test_skip_docker_operator[kwargs15-100-skipped] - airflow.exceptions.AirflowException: Failed to establish connection to any given Docker hosts.
========== 13 failed, 2176 passed, 3907 skipped in 568.84s (0:09:28) ===========

https://github.com/apache/airflow/actions/runs/9170171878/job/25212114821?pr=39714#step:7:10114

@Taragolis traced the issue to docker/docker-py#3256 which is caused by psf/requests#6707 for the moment lets pin request version till they release a fix

@Taragolis
Copy link
Contributor

Maybe better add requests>=2.27.0,<2.32.0 as dependency for Docker Provider and pin it here, and keep other providers unchanged?

As far as I understand changes in 2.32.x affect only docker-py lib, if someone do not need to use Docker Provider, then they could use requests up to request 3 (which not released yet)

@potiuk potiuk merged commit 1da7f1f into apache:main May 21, 2024
@eladkal eladkal deleted the docker branch May 21, 2024 15:52
potiuk added a commit to potiuk/airflow that referenced this pull request May 22, 2024
The botocore upgrade test brings also requests to latest version
even if it is limited in `[docker]` extra after apache#39740. This PR
adds similar limit when botocore is upgraded.
potiuk added a commit that referenced this pull request May 22, 2024
The botocore upgrade test brings also requests to latest version
even if it is limited in `[docker]` extra after #39740. This PR
adds similar limit when botocore is upgraded.
utkarsharma2 pushed a commit that referenced this pull request Jul 8, 2024
* Pin requests due to incompatibility with docker-py

* fix

(cherry picked from commit 1da7f1f)
utkarsharma2 pushed a commit that referenced this pull request Jul 8, 2024
The botocore upgrade test brings also requests to latest version
even if it is limited in `[docker]` extra after #39740. This PR
adds similar limit when botocore is upgraded.

(cherry picked from commit 39269d6)
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 8, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.9.3 milestone Jul 8, 2024
utkarsharma2 pushed a commit that referenced this pull request Jul 8, 2024
* Pin requests due to incompatibility with docker-py

* fix

(cherry picked from commit 1da7f1f)
utkarsharma2 pushed a commit that referenced this pull request Jul 8, 2024
The botocore upgrade test brings also requests to latest version
even if it is limited in `[docker]` extra after #39740. This PR
adds similar limit when botocore is upgraded.

(cherry picked from commit 39269d6)
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
* Pin requests due to incompatibility with docker-py

* fix
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
The botocore upgrade test brings also requests to latest version
even if it is limited in `[docker]` extra after apache#39740. This PR
adds similar limit when botocore is upgraded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:docker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants