[AIRFLOW-XXX] Pin docker requirement version #3975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The reason of failing seems to be time out. How to recheck it? |
ashb
reviewed
Sep 29, 2018
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Is there a reason to to update to 3, and fix the coffe code?
Codecov Report
@@ Coverage Diff @@
## master #3975 +/- ##
==========================================
- Coverage 75.79% 75.04% -0.75%
==========================================
Files 199 199
Lines 15946 15965 +19
==========================================
- Hits 12086 11981 -105
- Misses 3860 3984 +124
Continue to review full report at Codecov.
|
Contributor
Author
|
@ashb It passed. ^_^ |
Contributor
Author
|
When someone want to pip install the docker plugin on airflow, it could mislead the users to install the latest bags. It's a friendly tip. |
1 similar comment
Contributor
Author
|
When someone want to pip install the docker plugin on airflow, it could mislead the users to install the latest bags. It's a friendly tip. |
Contributor
|
Please create a Jira ticket for this, and mention the incompatibility with the |
…3919) The google auth provider hard-codes the `_scheme` in the callback url to `https` so that airflow generates correct urls when run behind a proxy that terminates tls. But this means that google auth can't be used when running without https--for example, during local development. Also, hard-coding `_scheme` isn't the correct solution to the problem of running behind a proxy. Instead, the proxy should be configured to set the `X-Forwarded-Proto` header to `https`; Flask interprets this header and generates the appropriate callback url without hard-coding the scheme.
* [AIRFLOW-3178] Don't mask defaults() function from ConfigParser ConfigParser (the base class for AirflowConfigParser) expects defaults() to be a function - so when we re-assign it to be a property some of the methods from ConfigParser no longer work. * [AIRFLOW-3178] Correctly escape percent signs when creating temp config Otherwise we have a problem when we come to use those values. * [AIRFLOW-3178] Use os.chmod instead of shelling out There's no need to run another process for a built in Python function. This also removes a possible race condition that would make temporary config file be readable by more than the airflow or run-as user The exact behaviour would depend on the umask we run under, and the primary group of our user, likely this would mean the file was readably by members of the airflow group (which in most cases would be just the airflow user). To remove any such possibility we chmod the file before we write to it
… aws_default connection extra parameters (#4011) Use profile for AWS hook if S3 config file provided in aws_default connection extra parameters Add test to validate profile set
To optimize query performance
Deleting Azure blob is now supported. Either single blobs can be deleted, or one can choose to supply a prefix, in which case one can match multiple blobs to be deleted.
The method "create_container" in APIClient of docker has been incompatible from version 3.0.0.
Contributor
Author
|
Reopened it at #4042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method "create_container" in APIClient of docker has been incompatible from version 3.0.0.