-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add mssql integration tests and relocate existing unit tests
#39831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f83ab8f to
4e900b1
Compare
4e900b1 to
29e3701
Compare
mssql integration testsmssql integration tests and relocate existing unit tests
tests/integration/providers/google/cloud/transfers/test_mssql_to_gcs.py
Outdated
Show resolved
Hide resolved
|
Nice. - few nits and solving failing tests (I guess some rebase needed?) |
29e3701 to
c0ca8c5
Compare
|
One more thing: you also need to add Mssql as individual integration to test in |
c0ca8c5 to
42d4c49
Compare
|
Nice! |
|
@eladkal @shahar1 I also added #39866 as follow-up -> I realized that the last step was not obvious (having to add integration test step to integration-tests.yml was quite a bit duplication - also recently the "self-hosted" "all-testable" integrations when all of the integrations are started together have been somewhat flaky (as opposed to individual integrations) - so the #39866 will simplify it: removes the duplication and always runs the integration tests individually on public runners for both mssql and postgres. |
closes: #38577
This PR:
mssqlfrom the integration directory back to the unit tests (see Restore providers' unit tests marked as integration tests #39768)mssql.mssqlhook.bigquery_to_mssql.pymssql_to_gcs.pymssql_to_hive.pycc: @potiuk, @Taragolis, @eladkal
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.