Change regular expression to exclude double quote and newline #39991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change tackles a change in Cloud Composer's default storage mechanism for logs as documented in the release notes on [March 26, 2024](https://cloud.google.com/composer/docs/release-notes#March_26_2024) and [May 11, 2024](https://cloud.google.com/composer/docs/release-notes#May_11_2024). This causes issue for Beam operator which uses regular expression to identify the Dataflow Job ID from the logs.
boring-cyborg
bot
added
area:providers
provider:google
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
potiuk
approved these changes
Jun 1, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
…#39991) This change tackles a change in Cloud Composer's default storage mechanism for logs as documented in the release notes on [March 26, 2024](https://cloud.google.com/composer/docs/release-notes#March_26_2024) and [May 11, 2024](https://cloud.google.com/composer/docs/release-notes#May_11_2024). This causes issue for Beam operator which uses regular expression to identify the Dataflow Job ID from the logs. Co-authored-by: Yuan Chuan Kee <1683885+kylase@users.noreply.github.com>
96 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…#39991) This change tackles a change in Cloud Composer's default storage mechanism for logs as documented in the release notes on [March 26, 2024](https://cloud.google.com/composer/docs/release-notes#March_26_2024) and [May 11, 2024](https://cloud.google.com/composer/docs/release-notes#May_11_2024). This causes issue for Beam operator which uses regular expression to identify the Dataflow Job ID from the logs. Co-authored-by: Yuan Chuan Kee <1683885+kylase@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tackles a change in Cloud Composer's default storage mechanism for logs as documented in the release notes on March 26, 2024 and May 11, 2024. This causes issue for Beam operator which uses regular expression to identify the Dataflow Job ID from the logs.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.