Add `CloudRunServiceHook` and `CloudRunCreateServiceOperator` #40008

jx2lee · 2024-06-02T06:38:50Z

Add Google Cloud Run Operators for Service

Closes: Add CloudRunCreateServiceOperator to Google Provider #38760

boring-cyborg · 2024-06-02T06:38:54Z

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
Be sure to read the Airflow Coding style.
Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

shahar1

Looks good overall!
There are a few nitpicks, and there's one failing test in the CI related to the system test which should be fixed.
Also, did you check yourself that it runs properly?

@VladaZakharova Would you like to take another look? :)

airflow/providers/google/cloud/operators/cloud_run.py

tests/system/providers/google/cloud/cloud_run/example_cloud_run_service.py

Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>

jx2lee · 2024-06-07T14:19:39Z

@shahar1 CI test that was failed have now passed!

tests/system/providers/google/cloud/cloud_run/example_cloud_run_service.py

jx2lee · 2024-06-10T02:33:29Z

@shahar1 Thanks for review! 🫡

airflow/providers/google/cloud/operators/cloud_run.py

tests/system/providers/google/cloud/cloud_run/example_cloud_run_service.py

airflow/providers/google/cloud/operators/cloud_run.py

tests/providers/google/cloud/hooks/test_cloud_run.py

tests/providers/google/cloud/operators/test_cloud_run.py

tests/system/providers/google/cloud/cloud_run/example_cloud_run_service.py

jx2lee · 2024-07-16T15:35:49Z

@VladaZakharova could you review changed?

shahar1 · 2024-08-02T20:27:19Z

@VladaZakharova could you review changed?

@jx2lee - It seems that static checks + tests fail, could you please check it out and fix?

jx2lee · 2024-08-04T06:54:44Z

@VladaZakharova could you review changed?

@jx2lee - It seems that static checks + tests fail, could you please check it out and fix?

@shahar1 i fixed that. Sorry for not checking for static & tests. 🥲

shahar1

A couple of more comments - please resolve when you're done :)

airflow/providers/google/cloud/operators/cloud_run.py

tests/system/providers/google/cloud/cloud_run/example_cloud_run_service.py

VladaZakharova

Thank you for changes! Left some comments
Did you run system tests locally to check if the DAG works fine?

airflow/providers/google/cloud/operators/cloud_run.py

tests/providers/google/cloud/operators/test_cloud_run.py

tests/system/providers/google/cloud/cloud_run/example_cloud_run_service.py

jx2lee · 2024-08-10T03:40:36Z

Thank you for changes! Left some comments

Did you run system tests locally to check if the DAG works fine?

Sure, i checked DAG works fine!

eladkal

LGTM

…#40008) * init cloud_run service hook & operator * init docs * added example_cloud_run_service * remove parent init Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com> * apply reveiw - more clearer * typo * add ENV_ID in system tests * validate inputs * add deleteOperator & test * typo * modified second review * 404/409 case in operator * pass static checks * typo * modified service creation in hook & operator * fixed by reviews in tests * modified docs * fixed test code to success * modified hook * add exceptions * modified test codes * static checks --------- Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>

boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 2, 2024

jx2lee added 2 commits June 2, 2024 23:16

init cloud_run service hook & operator

b1593d4

init docs

7274be0

jx2lee force-pushed the cloud-run-service branch from 2e0d6c2 to 7274be0 Compare June 2, 2024 14:51

jx2lee and others added 2 commits June 6, 2024 22:29

added example_cloud_run_service

33c3214

Merge branch 'main' into cloud-run-service

ec1d2bd

jx2lee marked this pull request as ready for review June 6, 2024 13:31

shahar1 reviewed Jun 7, 2024

View reviewed changes

airflow/providers/google/cloud/operators/cloud_run.py Outdated Show resolved Hide resolved

tests/system/providers/google/cloud/cloud_run/example_cloud_run_service.py Show resolved Hide resolved

remove parent init

2d04ea2

Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>

shahar1 reviewed Jun 8, 2024

View reviewed changes

tests/system/providers/google/cloud/cloud_run/example_cloud_run_service.py Show resolved Hide resolved

jx2lee added 2 commits June 9, 2024 12:18

apply reveiw - more clearer

fc8ae57

typo

b745548

shahar1 approved these changes Jun 9, 2024

View reviewed changes

Merge branch 'main' into cloud-run-service

1ad807f

VladaZakharova suggested changes Jun 14, 2024

View reviewed changes

jx2lee and others added 5 commits June 15, 2024 01:50

add ENV_ID in system tests

99b6cb2

validate inputs

54eafec

Merge branch 'main' into cloud-run-service

ed487ee

add deleteOperator & test

3b6a0a8

typo

e782775

VladaZakharova suggested changes Jun 19, 2024

View reviewed changes

jx2lee added 2 commits June 22, 2024 02:02

modified second review

0870ea3

404/409 case in operator

031ac20

jx2lee requested a review from VladaZakharova June 22, 2024 14:50

jx2lee force-pushed the cloud-run-service branch 4 times, most recently from 17f4b5f to f49f454 Compare August 4, 2024 06:28

pass static checks

0cf14fd

jx2lee force-pushed the cloud-run-service branch from f49f454 to 0cf14fd Compare August 4, 2024 06:35

eladkal changed the title ~~Add CloudRunServiceHook and operator (create)~~ Add CloudRunServiceHook and CloudRunCreateServiceOperator Aug 4, 2024

shahar1 approved these changes Aug 4, 2024

View reviewed changes

shahar1 reviewed Aug 4, 2024

View reviewed changes

airflow/providers/google/cloud/operators/cloud_run.py Outdated Show resolved Hide resolved

tests/system/providers/google/cloud/cloud_run/example_cloud_run_service.py Show resolved Hide resolved

typo

60d2e9b

VladaZakharova suggested changes Aug 5, 2024

View reviewed changes

jx2lee added 8 commits August 6, 2024 22:40

modified service creation in hook & operator

0c7051e

fixed by reviews in tests

d722780

modified docs

8126166

fixed test code to success

0ed4e10

modified hook

cfa43cd

add exceptions

146c205

modified test codes

216419a

static checks

4a01aee

eladkal approved these changes Aug 10, 2024

View reviewed changes

shahar1 self-requested a review August 10, 2024 08:59

shahar1 approved these changes Aug 10, 2024

View reviewed changes

eladkal merged commit 0aad0c8 into apache:main Aug 10, 2024

eladkal mentioned this pull request Aug 19, 2024

Status of testing Providers that were prepared on August 19, 2024 #41577

Closed

43 tasks

Add CloudRunServiceHook and CloudRunCreateServiceOperator #40008

Add CloudRunServiceHook and CloudRunCreateServiceOperator #40008

Uh oh!

Conversation

jx2lee commented Jun 2, 2024

Uh oh!

boring-cyborg bot commented Jun 2, 2024

Uh oh!

shahar1 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jx2lee commented Jun 7, 2024

Uh oh!

Uh oh!

jx2lee commented Jun 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jx2lee commented Jul 16, 2024

Uh oh!

shahar1 commented Aug 2, 2024

Uh oh!

jx2lee commented Aug 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shahar1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

VladaZakharova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jx2lee commented Aug 10, 2024

Uh oh!

eladkal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add `CloudRunServiceHook` and `CloudRunCreateServiceOperator` #40008

Add `CloudRunServiceHook` and `CloudRunCreateServiceOperator` #40008

shahar1 left a comment •

edited

Loading

jx2lee commented Aug 4, 2024 •

edited

Loading