sftp_sensor: fixing resource management with sensor #40022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pateash
force-pushed
the
pateash/sftp-sensor-connection-issue
branch
from
f64a94a to
fef455a
Compare
pateash
force-pushed
the
pateash/sftp-sensor-connection-issue
branch
from
9dc8708 to
d28d5fe
Compare
pankajkoti
reviewed
Jun 7, 2024
Member
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
Thanks for fixing this @pateash . I have a small suggestion inline.
pankajkoti
approved these changes
Jun 7, 2024
96 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
closes: apache#39922 Summary When a user tries to use the SFTPSensor operator with deferrable=True, using path/newer_than, it will open a connection and remain open, the reason is because of method get_mod_time in opening a sftp connection but not closing it afterward. As part of this change, we are closing the connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #39922
Summary
When a user tries to use the SFTPSensor operator with
deferrable=True, using path/newer_than, it will open a connection and remain open, the reason is because of methodget_mod_timein opening a sftp connection but not closing it afterward.As part of this change, we are closing the connection.