Remove explicitly specified folders when they are already ignored #40037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are running compatibility tests, some providers might be explicitly selected because PRs are running selective checks and the provider is seen as "affected" by the change. However, when we are runing compatibility tests, we sometimes want to exclude providers via `--skip-providers` flag because those providers might be incompatible with the version of Airflow we test. In case both - selective checks selects a provider and --skip-providers is set for those providers we now remove the explicitly specified provider from the list of pytest args.
eladkal
approved these changes
Jun 4, 2024
potiuk
deleted the
remove-explicitly-specified-providers-when-skipping-them
branch
fdemiane
pushed a commit
to fdemiane/airflow
that referenced
this pull request
Jun 6, 2024
…ache#40037) When we are running compatibility tests, some providers might be explicitly selected because PRs are running selective checks and the provider is seen as "affected" by the change. However, when we are runing compatibility tests, we sometimes want to exclude providers via `--skip-providers` flag because those providers might be incompatible with the version of Airflow we test. In case both - selective checks selects a provider and --skip-providers is set for those providers we now remove the explicitly specified provider from the list of pytest args.
syedahsn
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 7, 2024
…ache#40037) When we are running compatibility tests, some providers might be explicitly selected because PRs are running selective checks and the provider is seen as "affected" by the change. However, when we are runing compatibility tests, we sometimes want to exclude providers via `--skip-providers` flag because those providers might be incompatible with the version of Airflow we test. In case both - selective checks selects a provider and --skip-providers is set for those providers we now remove the explicitly specified provider from the list of pytest args.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…ache#40037) When we are running compatibility tests, some providers might be explicitly selected because PRs are running selective checks and the provider is seen as "affected" by the change. However, when we are runing compatibility tests, we sometimes want to exclude providers via `--skip-providers` flag because those providers might be incompatible with the version of Airflow we test. In case both - selective checks selects a provider and --skip-providers is set for those providers we now remove the explicitly specified provider from the list of pytest args.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are running compatibility tests, some providers might be explicitly selected because PRs are running selective checks and the provider is seen as "affected" by the change. However, when we are runing compatibility tests, we sometimes want to exclude providers via
--skip-providersflag because those providers might be incompatible with the version of Airflow we test.In case both - selective checks selects a provider and --skip-providers is set for those providers we now remove the explicitly specified provider from the list of pytest args.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.