Skip to content

Conversation

@amirmor1
Copy link
Contributor

@amirmor1 amirmor1 commented Jun 4, 2024

Added template_field 'job_id' in DataplexGetDataQualityScanResultOperator since the job_id is a returned value from DataplexRunDataQualityScanOperator, giving the ability to trigger DataplexGetDataQualityScanResultOperator without the need for it to make List requests to Dataplex API


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

amirmor1 added 2 commits June 4, 2024 10:03
Add job_id to template_fields, in order to easily provide returned value from DataplexRunDataQualityScanOperator (the returned value is the triggered job_id), to avoid List operations
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 4, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 4, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@josh-fell josh-fell merged commit f6148e6 into apache:main Jun 4, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 4, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@josh-fell
Copy link
Contributor

Congrats @amirmor1! 🎉

fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
Add job_id to template_fields, in order to easily provide returned value from DataplexRunDataQualityScanOperator (the returned value is the triggered job_id), to avoid List operations
syedahsn pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jun 7, 2024
Add job_id to template_fields, in order to easily provide returned value from DataplexRunDataQualityScanOperator (the returned value is the triggered job_id), to avoid List operations
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Add job_id to template_fields, in order to easily provide returned value from DataplexRunDataQualityScanOperator (the returned value is the triggered job_id), to avoid List operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants