openlineage: isolate metadata extraction by executing OL methods in separate, forked process #40078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobuchowski
requested review from
XD-DENG,
ashb,
kaxil,
mik-laj and
potiuk
as code owners
boring-cyborg
bot
added
area:providers
area:Scheduler
mobuchowski
force-pushed
the
openlineage-process-execution
branch
4 times, most recently
from
2c96acb to
44ba855
Compare
potiuk
reviewed
Jun 8, 2024
mobuchowski
force-pushed
the
openlineage-process-execution
branch
3 times, most recently
from
69865d6 to
7c13f5d
Compare
potiuk
reviewed
Jun 11, 2024
potiuk
reviewed
Jun 11, 2024
potiuk
reviewed
Jun 11, 2024
potiuk
reviewed
Jun 11, 2024
potiuk
reviewed
Jun 11, 2024
potiuk
reviewed
Jun 11, 2024
potiuk
reviewed
Jun 11, 2024
potiuk
reviewed
Jun 11, 2024
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
few nits about splitting the PR
Member
|
Ah I missed those are two commits/PRs already :) |
mobuchowski
force-pushed
the
openlineage-process-execution
branch
2 times, most recently
from
d863e62 to
55e5792
Compare
mobuchowski
force-pushed
the
openlineage-process-execution
branch
from
55e5792 to
8cbb8bc
Compare
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowski
force-pushed
the
openlineage-process-execution
branch
from
8cbb8bc to
187d87e
Compare
potiuk
approved these changes
Jun 14, 2024
96 tasks
20 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…ss (apache#40078) Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #39890 (already merged).
After this change, OpenLineage will execute metadata extraction in separate, forked process.
It's a technique modeled to what interaction between
LocalTaskJobRunnerandStandardTaskRunnerlooks like - a process, in this case process ofStandardTaskRunnerwatches over OpenLineage listener process during metadata extraction.This adds a layer of isolation between task execution and OpenLineage, adding a level of assurance that OpenLineage execution does not interfere with task execution in a way other than taking time.
Additionally, this allows us to add configurable timeout for OL execute methods.
The reason for that is, beyond configurability, that sometimes metadata extraction code can hang - for example, when dealing with Snowflake connection issue snowflakedb/snowflake-connector-python#1898 - and we want to give as much guarantees that OL will not cause task to fail.