Skip to content

Conversation

@molcay
Copy link
Contributor

@molcay molcay commented Jun 5, 2024

This PR is about upgrading the google-ads version which is a dependency for google providers


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 5, 2024
@molcay molcay changed the title Bump google-ads version Upgrade google-ads version Jun 5, 2024
@molcay molcay force-pushed the feat/upgrade-google-ads-api-version branch from 1431f88 to e4a1d01 Compare June 6, 2024 06:29
@ahidalgob
Copy link
Contributor

Hi, is this because of a new API version? should we update also the default_api_version in GoogleAdsHook?

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes here - yeah, we need to know the reason for that bump? Similarly to #40073 - we generally do not bump deps unless we have a reason for it.

@molcay
Copy link
Contributor Author

molcay commented Jun 7, 2024

Hi @ahidalgob,

Hi, is this because of a new API version?

Yes, we have a new API version on Google Ads.

should we update also the default_api_version in GoogleAdsHook?

Since it is a minor version upgrade this is not possible. Otherwise, we are also updating the default_api_version variable.

But it seems like we already have a new version (which is a major version upgrade): v17 https://developers.google.com/google-ads/api/docs/sunset-dates

Hi @potiuk,
The Google Ads API tends to be deprecated too quickly. So we are trying to keep up by upgrading the API versions preemptively. Actually, there is already a new version v17 and this version(v16.1) marked as deprecated. Here is the link for the version's timetable: https://developers.google.com/google-ads/api/docs/sunset-dates

So I think this PR can close without merge I will prepare a new PR with the new API version.

@molcay molcay closed this Jun 7, 2024
@molcay molcay deleted the feat/upgrade-google-ads-api-version branch June 7, 2024 09:48
@potiuk
Copy link
Member

potiuk commented Jun 7, 2024

So I think this PR can close without merge I will prepare a new PR with the new API version.

Yeah. Thanks for the context. Agree. Seems like Google Ads should be bumped earlier rather than later :)

@molcay
Copy link
Contributor Author

molcay commented Jun 10, 2024

Yes, definitely. I created the v17's PR already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants