Add delete_topic to KafkaAdminClientHook and teardown logic to Kafka integration tests
#40142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahar1
force-pushed
the
improve-kafka-hooks-integration-tests
branch
from
44cb2ba to
8b5245e
Compare
shahar1
force-pushed
the
improve-kafka-hooks-integration-tests
branch
from
8b5245e to
f16e2ea
Compare
shahar1
force-pushed
the
improve-kafka-hooks-integration-tests
branch
from
f16e2ea to
28d36ac
Compare
potiuk
approved these changes
Jun 8, 2024
This was referenced Jun 8, 2024
96 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…fka integration tests (apache#40142) * Add unit tests to Apache Kafka hooks * Add teardown logic to integration tests of kafka hooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on: #40140
This PR:
delete_topictoKafkaAdminClientHook.delete_topicabove, it adds teardown logic to integration tests of Kafka hooks. Without this logic, some of the tests may fail upon rerunning.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.