Remove flaky test case of deferred instance state for served logs #40257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test works fine when running it on local, but fails in CI. Setting up a correct DEFERRED task instance that behaves consistently seems to require more work, so removing this parameterized case for now.
Contributor
|
In addition to the comment in the code, could you open an Issue with details so someone might pick it up? |
ferruzzi
approved these changes
Jun 17, 2024
Member
Yeah. that's what we usually do. Create an issue and link to it from the TODO comment. |
ephraimbuddy
approved these changes
Jun 19, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #39496 and the aftermath of it.
In that PR tests for served logs were added for other instance states than
TaskInstanceState.RUNNING, includingTaskInstanceState.UP_FOR_RETRY(added in the PR) andTaskInstanceState.DEFERRED(not added in the PR).However, as it was briefly discussed in the PR and was later discovered, the current testing setup does not seem to guarantee consistent behavior for
TaskInstanceState.DEFERRED, as the tests succeed in local, but fail in the CI.This PR removes the testing of the state
TaskInstanceState.DEFERRED, as it was not the main purpose of #39496 but was rather an attempt to add better testing coverage for old behavior cases as well.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.