Fix mypy problems in new waeviate client #40330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new waeviate client (4.6.5) has more typing information and it causes Waeviate Hook to fail mypy check. This PR fixes it.
vincbeck
approved these changes
Jun 19, 2024
eladkal
approved these changes
Jun 19, 2024
utkarsharma2
pushed a commit
that referenced
this pull request
Jul 3, 2024
The new waeviate client (4.6.5) has more typing information and it causes Waeviate Hook to fail mypy check. This PR fixes it. (cherry picked from commit d048122)
utkarsharma2
added
the
changelog:skip
utkarsharma2
pushed a commit
that referenced
this pull request
Jul 8, 2024
The new waeviate client (4.6.5) has more typing information and it causes Waeviate Hook to fail mypy check. This PR fixes it. (cherry picked from commit d048122)
This was referenced Jul 9, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
The new waeviate client (4.6.5) has more typing information and it causes Waeviate Hook to fail mypy check. This PR fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new waeviate client (4.6.5) has more typing information and it causes Waeviate Hook to fail mypy check. This PR fixes it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.