Skip to content

openlineage: provide stack trace under proper key in error facet #40372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jun 24, 2024
Merged

openlineage: provide stack trace under proper key in error facet #40372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions airflow/providers/openlineage/plugins/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,11 +295,17 @@ def fail_task(
"""
error_facet = {}
if error:
if isinstance(error, BaseException):
stack_trace = None
if isinstance(error, BaseException) and error.__traceback__:
import traceback

error = "\\n".join(traceback.format_exception(type(error), error, error.__traceback__))
error_facet = {"errorMessage": ErrorMessageRunFacet(message=error, programmingLanguage="python")}
stack_trace = "\\n".join(traceback.format_exception(type(error), error, error.__traceback__))

error_facet = {
"errorMessage": ErrorMessageRunFacet(
message=str(error), programmingLanguage="python", stackTrace=stack_trace
)
}

event = RunEvent(
eventType=RunState.FAIL,
Expand Down
4 changes: 4 additions & 0 deletions tests/providers/openlineage/plugins/test_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,7 @@ def test_emit_failed_event_with_additional_information(mock_stats_incr, mock_sta
run_facets={"externalQuery": ExternalQueryRunFacet(externalQueryId="123", source="source")},
job_facets={"sql": SqlJobFacet(query="SELECT 1;")},
),
error=ValueError("Error message"),
)

assert (
Expand All @@ -476,6 +477,9 @@ def test_emit_failed_event_with_additional_information(mock_stats_incr, mock_sta
job={"namespace": namespace(), "name": "parent_job_name"},
),
"externalQuery": ExternalQueryRunFacet(externalQueryId="123", source="source"),
"errorMessage": ErrorMessageRunFacet(
message="Error message", programmingLanguage="python", stackTrace=None
),
},
),
job=Job(
Expand Down