Skip to content

Conversation

@dstandish
Copy link
Contributor

Missed this when implementing #39336. Need to increment try number for empty operator too.

@dstandish dstandish requested a review from jedcunningham June 25, 2024 23:43
@dstandish dstandish requested review from XD-DENG, ashb and kaxil as code owners June 25, 2024 23:43
@vincbeck
Copy link
Contributor

Interesting, I did not know we where making an exception for EmptyOperator. What is the reason behind? Just optimization purposes? I am just wondering if it is worth it and we should not just treat it as any regular operator

@dstandish
Copy link
Contributor Author

Interesting, I did not know we where making an exception for EmptyOperator. What is the reason behind? Just optimization purposes? I am just wondering if it is worth it and we should not just treat it as any regular operator

Yeah. I don’t have a strong opinion. I would not be opposed to removing the logic. +0 you could say. I think it’s there because why send something to the worker to do nothing. But then we have all that logic cus if there’s callbacks etc

I don’t know why we need this operator in the first place. I’m not sure what the use is.

@jedcunningham
Copy link
Member

I love me some EmptyOp, but that's for my persona (Airflow dev). I'd bet some 🍻 that the vast majority of EmptyOps in the wild could go away.

@jedcunningham jedcunningham merged commit 6694f47 into apache:main Jun 26, 2024
@jedcunningham jedcunningham deleted the handle-empty-operator-try-number branch June 26, 2024 17:11
@utkarsharma2 utkarsharma2 added the type:improvement Changelog: Improvements label Jul 1, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.0 milestone Jul 1, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@utkarsharma2 utkarsharma2 added type:bug-fix Changelog: Bug Fixes and removed type:improvement Changelog: Improvements labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants