Skip to content

AIP-64: Add REST API endpoints for TI try level details #40441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ephraimbuddy merged 5 commits into from
Jul 22, 2024
Merged

AIP-64: Add REST API endpoints for TI try level details #40441

ephraimbuddy merged 5 commits into from
Jul 22, 2024

Conversation

@ephraimbuddy
Copy link
Contributor

@ephraimbuddy ephraimbuddy commented Jun 26, 2024

This PR adds REST API endpoints for task instance/mapped task instance try level details.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Jun 26, 2024
@ephraimbuddy ephraimbuddy force-pushed the add-ti-history-restapi-endpoint branch from 03f772a to 7a19cb8 Compare June 27, 2024 19:10
@ephraimbuddy ephraimbuddy marked this pull request as ready for review June 27, 2024 19:10
@ephraimbuddy ephraimbuddy force-pushed the add-ti-history-restapi-endpoint branch from 7a19cb8 to 3954417 Compare June 27, 2024 23:05
@phanikumv phanikumv requested review from Lee-W and pankajkoti July 3, 2024 06:35
Lee-W
Lee-W reviewed Jul 3, 2024
View reviewed changes
@vatsrahul1001
Copy link
Contributor

vatsrahul1001 commented Jul 9, 2024

@ephraimbuddy if a try number does not exist should we return 404 status code instead of 200?
image

@ephraimbuddy
Copy link
Contributor Author

ephraimbuddy commented Jul 9, 2024

@ephraimbuddy if a try number does not exist should we return 404 status code instead of 200? image

Looks like you are not using this endpoint? What I see there is log endpoint?

jedcunningham
jedcunningham reviewed Jul 10, 2024
View reviewed changes
@ephraimbuddy ephraimbuddy force-pushed the add-ti-history-restapi-endpoint branch from 7d90127 to 9b00ab4 Compare July 11, 2024 09:15
jedcunningham
jedcunningham previously approved these changes Jul 12, 2024
View reviewed changes
jedcunningham
jedcunningham reviewed Jul 12, 2024
View reviewed changes
@jedcunningham jedcunningham dismissed their stale review July 12, 2024 06:31

Want to think a bit more before 👍

@ephraimbuddy ephraimbuddy mentioned this pull request Jul 15, 2024
Merged
@ephraimbuddy ephraimbuddy force-pushed the add-ti-history-restapi-endpoint branch from 9b00ab4 to 0bcb5d7 Compare July 15, 2024 12:32
@bbovenzi
Copy link
Contributor

bbovenzi commented Jul 15, 2024

Are we planning to include a list endpoint in the REST API? Then we could get replace this webserver endpoint: https://github.com/apache/airflow/blob/main/airflow/www/views.py#L3616

@ephraimbuddy
Copy link
Contributor Author

ephraimbuddy commented Jul 15, 2024

Are we planning to include a list endpoint in the REST API? Then we could get replace this webserver endpoint: https://github.com/apache/airflow/blob/main/airflow/www/views.py#L3616

We can modify the existing get taskinstances endpoint to include the taskinstance history but looking at the view, it seems only to get the history part and not the current TI?

@ephraimbuddy
AIP-64: Add REST API endpoints for TI try level details
6962b21 
This PR adds REST API endpoints for task instance/mapped task instance try level details.
@ephraimbuddy
Add tests
bc33145
@ephraimbuddy
Fix query
81a2b94
@ephraimbuddy ephraimbuddy force-pushed the add-ti-history-restapi-endpoint branch from 0bcb5d7 to cf1a437 Compare July 19, 2024 19:12
Lee-W
Lee-W approved these changes Jul 22, 2024
View reviewed changes
@ephraimbuddy ephraimbuddy merged commit 8b111d1 into apache:main Jul 22, 2024
@ephraimbuddy ephraimbuddy deleted the add-ti-history-restapi-endpoint branch July 22, 2024 10:08
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) AIP-64 Task Instance history labels Jul 22, 2024
@ephraimbuddy ephraimbuddy added this to the Airflow 2.10.0 milestone Jul 23, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
@ephraimbuddy @romsharon98
AIP-64: Add REST API endpoints for TI try level details (apache#40441)
1369eab 
* AIP-64: Add REST API endpoints for TI try level details

This PR adds REST API endpoints for task instance/mapped task instance try level details.

* Add tests

* Fix query

* add more tests

* Remove relationships
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-W Lee-W Lee-W approved these changes

@phanikumv phanikumv phanikumv approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton

@ashb ashb Awaiting requested review from ashb

@bbovenzi bbovenzi Awaiting requested review from bbovenzi

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun

@kaxil kaxil Awaiting requested review from kaxil

@XD-DENG XD-DENG Awaiting requested review from XD-DENG

@pankajkoti pankajkoti Awaiting requested review from pankajkoti

@jedcunningham jedcunningham Awaiting requested review from jedcunningham

Assignees

No one assigned

Labels

AIP-64 Task Instance history area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Milestone

Airflow 2.10.0

Development

Successfully merging this pull request may close these issues.

6 participants

@ephraimbuddy @vatsrahul1001 @bbovenzi @Lee-W @jedcunningham @phanikumv