Skip to content

Conversation

@jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Oct 13, 2018

Note: this is an alternative to #4042. Does this make sense @deagon?

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Prior to docker-py 3.0, cpu and memory limits could be passed to either
create_container or create_host_config. After version 3.0, those
options can only be passed to create_host_config. To support current
versions of docker-py, pass resource limit options to
create_host_config.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes flake8

@jmcarp jmcarp force-pushed the update-docker-args branch 2 times, most recently from 114f2ff to 4e07ec9 Compare October 15, 2018 00:37
Prior to docker-py 3.0, cpu and memory limits could be passed to either
`create_container` or `create_host_config`. After version 3.0, those
options can only be passed to `create_host_config`. To support current
versions of docker-py, pass resource limit options to
`create_host_config`.
@jmcarp jmcarp force-pushed the update-docker-args branch from 4e07ec9 to a5974ed Compare October 15, 2018 13:51
@jmcarp
Copy link
Contributor Author

jmcarp commented Oct 17, 2018

I see that #4049 includes this fix. Let's go with that instead.

@jmcarp jmcarp closed this Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant