-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Tiny PR: Fix two typos in Weaviate provider code #40670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Nothing to be sorry about :) ! There are so many things happening that I am somewhat surprise I am able to follow it :D |
hussein-awala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a major release in case someone provides the extra grcp_secure or uses the public method get_collection_configuraiton.
If the change is not released yet, +1 to cancel the RC |
yes, the typos are not in any released version |
|
Thank @TJaniF for the prompt fixing. Didn't notice it 🤦♂️ |
Fixing
grcp->grpcandget_collection_configuraitontoget_collection_configurationboth of these typos were introduced in #40194 which has not been part of a released version yet, so does not break anything :)
cc: @Lee-W