Fix Custom Training Job operators to accept results without a model in def mode #40685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
provider:google
e-galan
force-pushed
the
fix-vertex-ai-custom-job-operators-def-mode
branch
from
d5c28b0 to
6ddda80
Compare
shahar1
reviewed
Jul 11, 2024
airflow/providers/google/cloud/operators/vertex_ai/custom_job.py
Outdated
Show resolved
Hide resolved
e-galan
force-pushed
the
fix-vertex-ai-custom-job-operators-def-mode
branch
from
6ddda80 to
cd71488
Compare
shahar1
approved these changes
Jul 12, 2024
potiuk
approved these changes
Jul 13, 2024
ephraimbuddy
added
the
changelog:skip
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #40476
Fix the deferrable mode for Custom Training Job operators so that they could process training pipeline results that do not produce a managed model due to incorrect configuration. This feature was present in the sync mode, but was not originally included into the deferrable mode.
Update the return values of the operators in the deferrable mode to return only the model data instead of the training pipeline data. This makes the deferrable mode behavior more similar to the sync mode.
Refactor the operators by moving repeating code blocks into their base class.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.