-
Notifications
You must be signed in to change notification settings - Fork 16.4k
DockerSwarmOperator: Support line breaks in service logs #40705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Please review |
|
Please review |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* fix: Support carriage return in logs * test: Add log tests for line breaks
closes: #40571
Since we use splitlines() on the decoded log string,
If the log line is
The
stream_new_logsfunction treats it as three separate log lines, which leads to failure in finding timestamp in carriage return separated lines.This PR changes the initial log pre-processing.
Since the log generator provided by docker's
service_logsis already separating log lines we don't need to usesplitlines().