Skip to content

Conversation

@vincbeck
Copy link
Contributor

Many Sagemaker operators tend to have the same issue. execute_complete uses some information saved in context. However, the node running execute might be different from the node running execute_complete, therefore, we should not assume any information saved in context. Ideally, execute_complete should use only information coming from event.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Jul 10, 2024
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find/fix

@potiuk potiuk merged commit a11d273 into apache:main Jul 11, 2024
@vincbeck vincbeck deleted the vincbeck/sm_operators_deferrable_consistency branch July 11, 2024 14:01
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants