Revert "Add DatabricksWorkflowPlugin" #40714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 22ec726.
jscheffl
requested review from
Lee-W,
ashb,
eladkal,
pankajastro,
pankajkoti and
potiuk
boring-cyborg
bot
added
area:plugins
area:providers
kind:documentation
provider:databricks
labels
pankajkoti
approved these changes
Jul 11, 2024
Member
pankajkoti
left a comment
pankajkoti
left a comment
There was a problem hiding this comment.
Thanks @jscheffl for observing and highlighting the concerns early on. I will address the concerns and create a new PR :)
pankajkoti
added a commit
that referenced
this pull request
Jul 12, 2024
The DatabricksWorkflowPlugin provides with links in the Airflow UI for tasks that allow us to see the Databricks job run in the Databricks workspace, additionally it also provides link to repair task(s) in the workflow. Databricks does not allow repairing jobs with single tasks launched outside the workflow, hence we just provide the link for the job run. Within the workflow, for each of the task, we provide links to the job run and repair link for the single task And at the workflow level, for the job launch task, we provide a link to repair all failed tasks along with the link for job run in the Databricks workspace that can be used to monitor the job in the Databricks account. This PR is the second attempt on adding the DatabricksWorkflowPlugin, the previous attempt being #40153. However, there were some concerns raised in #40708 and hence it was reverted in #40714. This newer PR attempts to address those concerns.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
This reverts commit 22ec726.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
The DatabricksWorkflowPlugin provides with links in the Airflow UI for tasks that allow us to see the Databricks job run in the Databricks workspace, additionally it also provides link to repair task(s) in the workflow. Databricks does not allow repairing jobs with single tasks launched outside the workflow, hence we just provide the link for the job run. Within the workflow, for each of the task, we provide links to the job run and repair link for the single task And at the workflow level, for the job launch task, we provide a link to repair all failed tasks along with the link for job run in the Databricks workspace that can be used to monitor the job in the Databricks account. This PR is the second attempt on adding the DatabricksWorkflowPlugin, the previous attempt being apache#40153. However, there were some concerns raised in apache#40708 and hence it was reverted in apache#40714. This newer PR attempts to address those concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40153
I attempted to fix the problems in #40708 but three problems remain in pytests, therefore I propose to revert this addition, fix it properly and bring it back later.
Main reason: security - if released.