Skip to content

Conversation

@ssilb4
Copy link
Contributor

@ssilb4 ssilb4 commented Jul 11, 2024

aws batch operator has no eks_properties_override. so I added it.

I found this

Closes: #40117


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@ssilb4 ssilb4 requested review from eladkal and o-nikolas as code owners July 11, 2024 08:23
@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Jul 11, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 11, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing from code formatting issues, but otherwise lgtm

@ssilb4
Copy link
Contributor Author

ssilb4 commented Jul 12, 2024

I changed test

@ssilb4
Copy link
Contributor Author

ssilb4 commented Jul 16, 2024

I think non-db test failure is not my fault.

@potiuk
Copy link
Member

potiuk commented Jul 16, 2024

Yep - it's being fixed in #40821

@vincbeck
Copy link
Contributor

vincbeck commented Jul 16, 2024

Yep - it's being fixed in #40821

Are you sure? I have the same issue in my PR #40823 and it is failing (fork and PR are rebased).

EDIT: it is in compact tests

@eladkal eladkal merged commit 4d45c00 into apache:main Aug 9, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 9, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EKS Overrides for AWS Batch submit_job

5 participants