Skip to content

DRAFT Add task instance event log table #40761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dstandish wants to merge 3 commits into from
Closed

DRAFT Add task instance event log table #40761

dstandish wants to merge 3 commits into from

Conversation

@dstandish
Copy link
Contributor

@dstandish dstandish commented Jul 12, 2024

draft!

@boring-cyborg boring-cyborg bot added area:Executors-core LocalExecutor & SequentialExecutor area:providers area:Scheduler including HA (high availability) scheduler provider:amazon AWS/Amazon - related issues labels Jul 12, 2024
@dstandish dstandish changed the title Add task instance event log table DRAFT Add task instance event log table Jul 12, 2024
@dstandish dstandish force-pushed the add-task-event-log-table branch from 55e1079 to 1447e99 Compare July 15, 2024 01:59
vincbeck
vincbeck reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Should we also deprecate/remove TaskContextLogger ?

airflow/api_connexion/schemas/event_log_schema.py Outdated
Copy link
Contributor

@vincbeck vincbeck Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy pasta

airflow/providers/amazon/aws/executors/ecs/ecs_executor.py Outdated
Copy link
Contributor

@vincbeck vincbeck Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"ECS task %s has failed %s times. Marking as failed. Reasons: %s" % task_key,
"ECS task %s has failed %s times. Marking as failed. Reasons: %s",

And pass task_key as first parameter

@dstandish dstandish force-pushed the add-task-event-log-table branch from 1447e99 to e1048d5 Compare July 16, 2024 20:21
@dstandish
Copy link
Contributor Author

dstandish commented Jul 17, 2024

closing in favor of #40739

@dstandish dstandish closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincbeck vincbeck vincbeck left review comments

Assignees

No one assigned

Labels

area:Executors-core LocalExecutor & SequentialExecutor area:providers area:Scheduler including HA (high availability) scheduler provider:amazon AWS/Amazon - related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dstandish @vincbeck