Introduce Amazon Kinesis Analytics V2 (Managed Service for Apache Flink application) #40765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
gopidesupavan
changed the title
vincbeck
reviewed
Jul 18, 2024
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
Some nits and questions but overall I am very impressed! Very good job! There is a lot of code but everything looks good to me :)
Member
Author
HI @vincbeck Thank you, Really appreciate your time and looking into this PR. Apologies for the more changes in single PR , was testing around start and stop application operators thought of pushing together all these. I will make sure next time will push small block 😄 |
vincbeck
approved these changes
Jul 18, 2024
Contributor
|
Awesome job! |
eladkal
reviewed
Jul 18, 2024
ephraimbuddy
added
the
changelog:skip
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Amazon Managed Service for Apache Flink . Doc, Operator, Sensor, Trigger, Waiter, Unit Test, System Test. Next will be adding Update configuration operator.
Manually tested in Breeze with.
wait_for_completion=False with a Sensor
deferrable=True.
wait_for_completion=True.
I am looking to use the DescribeApplicationOperation API to get more detailed error information when any application action is performed. Unfortunately, these calls are only available starting from Boto3 version 1.34.134, in provider config the boto3 configured >=1.30.90, but when the image gets build the version is coming 1.34.131. so in this cant use the above api.
So thought of updating it later the code to use the describe_application_operation API when the boto3 becomes >=1.34.134. Do you have any other suggestions?
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.