Prevent NoneType Error at plugin loading with database isolation mode #40770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
ashb,
bbovenzi,
pierrejeambrun and
ryanahamilton
as code owners
uranusjr
approved these changes
Jul 15, 2024
eladkal
approved these changes
Jul 15, 2024
ephraimbuddy
added
changelog:skip
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
jscheffl
deleted the
bugfix/sqlite-check-in-isolation-mode-with-example-plugins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merge of #39999 and the addition of the Databricks plugin (again) in #40724 I realized that in the chain of loading plugins with examples the loading of the databricks plugin fails is database isolation mode is on (AIP-44).
Background is that importing from views, here BaseView checks for DB Engine, which is not initialized.
Make check for SQlite conditional only if DB engine is initialized.