Have integration points for AIP-69 in Internal API #40901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
feature/have-integration-points-for-aip-69-in-internal-api
branch
from
39ff6f6 to
e8291d3
Compare
Member
|
I rebased it after I fixed selective checks in #40904 |
potiuk
reviewed
Jul 20, 2024
potiuk
approved these changes
Jul 21, 2024
hussein-awala
approved these changes
Jul 21, 2024
ephraimbuddy
added
AIP-44
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
* Have integration points for AIP-69 in Internal API * Allow adding custom classes into serialization mapping * Have integration points for AIP-69 in Internal API * Fix pytest, reverse validation check for scheme * Have integration points for AIP-69 in Internal API * Review feedback
jscheffl
deleted the
feature/have-integration-points-for-aip-69-in-internal-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to leverage the AIP-44 interface for AIP-69 / Remote Executor I need some small adjustments to "hook into" the RPC API. This PR extracts from PoC implementation of AIP-69 (#40900) the needed internal API adjustments:
_initialize_map()needs to be extended, not to replicate the function list I'd like to remove the private tag to extend it with a few methods in remote executor. Would not add it to be a "public" interface though.