Chart: add a specific internal IP address for the ClusterIP service #40912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alizmhdi
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
Contributor
Author
|
Hello @potiuk, |
Member
|
We avoid to call specific people unless we know they are related and interested here. I think there are other reviewers already automatically assigned here. if I am supposed to review every single PR here where others could do it as well - it's impossible with the amounts of PRs we have and very stressful in general - very mentally draining - so I deliberately limit the areas I am looking at. And chart is something I am not too "good at". Also, by mentioning me you are decreasing chance that others will take a look because they think I will, so try to avoid that. I suggest you just generally ask for review and wait. |
Contributor
|
changes looks good, can you add ut? |
romsharon98
approved these changes
Jul 28, 2024
jedcunningham
approved these changes
Aug 9, 2024
romsharon98
force-pushed
the
FEAT/add-pgbouncer-service-ip
branch
from
d0b2c6e to
9841150
Compare
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Aug 20, 2024
…pache#40912) * Chart: add a specific internal IP address for the ClusterIP service * Chart: Fix values schema for clusterIP in PgBouncer Service * Add unit-test for static ip in pgbouncer service * Fix typo in pgbouncer template * Fix static checks * Change name of ip to clusterIp in pgbouncer service * Fix helm tests for pgbouncer
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
closes: #40676
add a specific internal IP address for the ClusterIP service in helm chart.