openlineage: extend custom_run_facets to on_failed and on_complete #40953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:openlineage
kacpermuda
force-pushed
the
ol-extend-custom-run-facets
branch
from
9d90140 to
d14811a
Compare
JDarDagran
approved these changes
Jul 23, 2024
mobuchowski
reviewed
Jul 23, 2024
kacpermuda
force-pushed
the
ol-extend-custom-run-facets
branch
2 times, most recently
from
d40d1cc to
7e00041
Compare
Contributor
Author
|
Let's wait with merging this one until #39530 gets merged, so @JDarDagran does not have to rebase all the time cause of new facet imports appearing. |
… and fail Signed-off-by: Kacper Muda <mudakacper@gmail.com>
kacpermuda
force-pushed
the
ol-extend-custom-run-facets
branch
from
7e00041 to
2eb4ce7
Compare
mobuchowski
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending what was implemented in #38982. Now we will allow users to attach their custom run facets to all task events, regardless of the task state. This feature is not yet released, so there is no need for keeping any compatibility.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.