Skip to content

Conversation

@JDarDagran
Copy link
Contributor

Implements approach proposed in #40971.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

state change level OpenLineage listener hooks.

Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
@kacpermuda
Copy link
Contributor

Quick question, if the default behaviour changed and all Facets in v2 have the slots=True why not change all the Airflow facets to mimic that and not only the ones that go to DAG events and undergo pickling. Is that impacting the performance a lot? Is there any other point here that we are worried about? For the sake of simplicity and to avoid mistakes i think it would be good to keep it consistent. If not, let's at least leave a comment / docstring somewhere in the code about why sometimes it's False and sometimes it's True.

@JDarDagran
Copy link
Contributor Author

Quick question, if the default behaviour changed and all Facets in v2 have the slots=True why not change all the Airflow facets to mimic that and not only the ones that go to DAG events and undergo pickling. Is that impacting the performance a lot? Is there any other point here that we are worried about? For the sake of simplicity and to avoid mistakes i think it would be good to keep it consistent. If not, let's at least leave a comment / docstring somewhere in the code about why sometimes it's False and sometimes it's True.

I agree, for the sake of simplicity it'd be better to have all facets set slots to True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants