Skip to content

Conversation

@got686-yandex
Copy link
Contributor

Typing changes for yandex-cloud/python-sdk (yandexcloud pypi package) types.
yandex-cloud/python-sdk#106

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 24, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@got686-yandex got686-yandex force-pushed the fix_provider_yandex_typing branch from 8a5a19c to a69091b Compare July 24, 2024 13:12
@Piatachock
Copy link
Contributor

@potiuk hi, Jarek! Here are fixes for typing in both yandexcloud/python-sdk and Yandex Airflow provider itself. Hope it allows unlocking our provider version 🙏

@Piatachock
Copy link
Contributor

LGTM from Yandex

@got686-yandex got686-yandex force-pushed the fix_provider_yandex_typing branch 2 times, most recently from 0febca9 to d4827f1 Compare July 29, 2024 19:46
@got686-yandex got686-yandex force-pushed the fix_provider_yandex_typing branch from d4827f1 to 14d0db1 Compare July 29, 2024 19:50
@got686-yandex
Copy link
Contributor Author

@potiuk , good day, can you start full checks?

@Benz19933
Copy link

Bld

@potiuk potiuk merged commit 2daa5bd into apache:main Aug 4, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 4, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@got686-yandex got686-yandex deleted the fix_provider_yandex_typing branch August 22, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants