Make EMR Container Trigger max attempts retries match the Operator #41008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EMR Container Operator will wait indefinitely by default (on the wait for completion path) however when it is deferred the Trigger has a default timeout of 600s which does not match the user's expectations when using the operator. Update the Trigger to have an infinite try count by default to match the Operator behaviour.
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
approved these changes
Jul 24, 2024
Contributor
Author
|
Can you have a look at this in regards to your issue #40483 |
eladkal
approved these changes
Jul 24, 2024
|
Thanks, a lot it seems it would solve part of our problems! :) |
syedahsn
approved these changes
Jul 26, 2024
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EMR Container Operator will wait indefinitely by default (on the wait for completion path) however when it is deferred the Trigger has a default timeout of 600s which does not match the user's expectations when using the operator.
Update the Trigger to have an infinite try count by default to match the Operator behaviour.
fixes #40483
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.