fix: call listener manager on_task_instance_failed() after ti state is changed #41053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
potiuk
approved these changes
Jul 26, 2024
Member
|
Makes sense. But would love other look :) |
mobuchowski
approved these changes
Aug 1, 2024
jedcunningham
added
type:bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we are calling
get_listener_manager().hook.on_task_instance_failedwithtithat still has theRUNNINGstate assigned. By using onlyti.state, there is no way of knowing if it failed or not, it looks the same as the one being passed toget_listener_manager().hook.on_task_instance_start.We should probably move the listener call to after, we assign the
FAILEDorUP_FOR_RETRYstate, so that we can use that information. I've tested this change and it looks like there is no influence on any other part of code, but maybe I'm missing something.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.