Fix broken/renamed internal API method #41070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yeah. I also found it and fixed in #41067 - so yeah. That's exactly what will not happen when we run the tests :D |
Member
|
And yeah. By implementing the test you already implemented This one |
potiuk
approved these changes
Jul 27, 2024
Contributor
Author
I would say the pytest is 50% of it. Still you could add the decorator and miss listing the method in the method-map. Then the test will not fail. |
Member
|
Agreed :) |
jedcunningham
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rebasing I realized that one mapped method in internal API was renamed and broke the internal API.
This PR fixes back to the correct name.
@potiuk How could this happen if internal API is used in CI tests? I thought this is enabled now? Do we need another safety-net?
To prevent regression I added a pytest to check that method-map can be built, means this will fail if any method is moving-away