Issue-41243 Unpin the moto dependency #41256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vikramaditya91
force-pushed
the
bugfix/issue-41243-fix-moto-version-pin
branch
from
fd90d5a to
1893dcd
Compare
Member
|
The tests should also be made compatible with older versions of Airflow / moto constraints - as we are running the same tests with older versions of Airflow as well, so I guess checking for both variants should solve it. |
vikramaditya91
force-pushed
the
bugfix/issue-41243-fix-moto-version-pin
branch
from
1893dcd to
e55e078
Compare
Contributor
Author
I see. Fixed it accordingly |
Member
|
You need to rebase and: |
vikramaditya91
force-pushed
the
bugfix/issue-41243-fix-moto-version-pin
branch
2 times, most recently
from
19647d2 to
000dbdb
Compare
vikramaditya91
force-pushed
the
bugfix/issue-41243-fix-moto-version-pin
branch
2 times, most recently
from
cbe6ba2 to
42bfbb1
Compare
Contributor
|
Tests are still failing, did you run |
Contributor
Author
|
I ran them, but they formatted the files as @@ -46,7 +46,7 @@
"devel-deps": [
"aiobotocore>=2.13.0",
"aws_xray_sdk>=2.12.0",
- "moto[cloudformation,glue]>=5.0.0",
+ "moto[cloudformation,glue]>=5.0.0,",
"mypy-boto3-appflow>=1.34.0",Not really sure, why it puts that comma after the Checking why that actually happens EDIT: Nevermind. There was a stupid error there. Fixed it |
vikramaditya91
force-pushed
the
bugfix/issue-41243-fix-moto-version-pin
branch
from
42bfbb1 to
8df3c68
Compare
vikramaditya91
force-pushed
the
bugfix/issue-41243-fix-moto-version-pin
branch
from
8df3c68 to
d3f9861
Compare
Contributor
Author
|
Looks like some unrelated tests are failing...:( |
vikramaditya91
force-pushed
the
bugfix/issue-41243-fix-moto-version-pin
branch
from
09009ba to
4828dd5
Compare
potiuk
force-pushed
the
bugfix/issue-41243-fix-moto-version-pin
branch
from
4828dd5 to
5a91b36
Compare
The exception should be `ExportTaskNotFound` (and not `ExportTaskNotFoundFault`) as recorded here: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribeExportTasks.html The moto version dependency pin is updated to reflect this. Older versions of moto will not succeed this test case, hence the version pin is bumped to 5.0.12
potiuk
force-pushed
the
bugfix/issue-41243-fix-moto-version-pin
branch
from
5a91b36 to
f486be0
Compare
potiuk
approved these changes
Aug 13, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Artuz37
pushed a commit
to Artuz37/airflow
that referenced
this pull request
Aug 19, 2024
The exception should be `ExportTaskNotFound` (and not `ExportTaskNotFoundFault`) as recorded here: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribeExportTasks.html The moto version dependency pin is updated to reflect this. Older versions of moto will not succeed this test case, hence the version pin is bumped to 5.0.12 Co-authored-by: Vikram Gaonkar <vikramaditya.gaonkar@imc.com>
43 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Aug 20, 2024
The exception should be `ExportTaskNotFound` (and not `ExportTaskNotFoundFault`) as recorded here: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribeExportTasks.html The moto version dependency pin is updated to reflect this. Older versions of moto will not succeed this test case, hence the version pin is bumped to 5.0.12 Co-authored-by: Vikram Gaonkar <vikramaditya.gaonkar@imc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception should be
ExportTaskNotFound(and notExportTaskNotFoundFault) as recorded here:https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribeExportTasks.html
closes: #41243
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.