Skip to content

Conversation

@moiseenkov
Copy link
Contributor

This PR upgrades the gcloud-aio-auth package constraints up to >=5.2.0.

As it was requested in the provider.yaml this PR overrides the following methods for the _CredentialsToken class:

  • refresh()
  • ensure_token() - this method is overridden in order to satisfy the unit test tests/providers/google/common/hooks/test_base_google.py::TestCredentialsToken::test_get

I also tested these changes with multiple system tests with deferrable mode, and they succeed.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Aug 5, 2024
@moiseenkov moiseenkov force-pushed the upgrade-gcloud-aio-auth branch 2 times, most recently from b1f89eb to 6deb17a Compare August 6, 2024 09:57
@moiseenkov moiseenkov requested a review from ashb as a code owner August 6, 2024 09:57
@moiseenkov moiseenkov force-pushed the upgrade-gcloud-aio-auth branch from 6deb17a to a24d3f8 Compare August 6, 2024 10:35
@moiseenkov moiseenkov requested a review from potiuk August 6, 2024 11:18
@moiseenkov
Copy link
Contributor Author

Hi @potiuk , @ashb ,
I made some changes in the scripts/docker/entrypoint_ci.sh to fix the CI. PTAL.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants