Skip to content

Conversation

@deagon
Copy link
Contributor

@deagon deagon commented Nov 3, 2018

Since the change of AIRFLOW-3203, the dockerpy client has upgraded
actually. Therefore, the requirements config should upgrade also to
avoid potentially misleading.

@XD-DENG @Fokko


Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

  • Passes flake8

Since the change of AIRFLOW-3203, the dockerpy client has upgraded
actually. Therefore, the requirements config should upgrade also to
avoid potentially misleading.
@deagon
Copy link
Contributor Author

deagon commented Nov 3, 2018

AIRFLOW-3203 linked to #4049.

@XD-DENG
Copy link
Member

XD-DENG commented Nov 3, 2018

Thanks @deagon . You're correct: one part of my PR (#4049) was to address the breaking change in docker==3.0.0 and we do need to pin the version for it.

This PR looks sensible to me.

@codecov-io
Copy link

Codecov Report

Merging #4130 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4130      +/-   ##
==========================================
+ Coverage   76.66%   76.67%   +<.01%     
==========================================
  Files         199      199              
  Lines       16212    16212              
==========================================
+ Hits        12429    12430       +1     
+ Misses       3783     3782       -1
Impacted Files Coverage Δ
airflow/models.py 92.09% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb22462...7351c6b. Read the comment docs.

@Fokko Fokko merged commit 24c9fb2 into apache:master Nov 5, 2018
@XD-DENG
Copy link
Member

XD-DENG commented Nov 7, 2018

Hi @ashb , would you mind to add this commit into 1.10.1?

Understand that my PR #4049 ([AIRFLOW-3203] Fix DockerOperator & some operator test) is already cherry-picked into branch v1-10-test. The change made in that PR is partially meant to address a breaking change in Python package docker==3.0.0. But I missed to pin the docker version in that commit. This may result in issues for users who have docker < 3.0.0 when they upgrade to 1.10.1.

Cheers.

@ashb
Copy link
Member

ashb commented Nov 7, 2018

@XD-DENG Ah cool. will do!

ashb pushed a commit that referenced this pull request Nov 7, 2018
Since the change of AIRFLOW-3203, the dockerpy client has upgraded
actually. Therefore, the requirements config should upgrade also to
avoid potentially misleading.
wyndhblb pushed a commit to asappinc/incubator-airflow that referenced this pull request Nov 9, 2018
Since the change of AIRFLOW-3203, the dockerpy client has upgraded
actually. Therefore, the requirements config should upgrade also to
avoid potentially misleading.
galak75 pushed a commit to VilledeMontreal/incubator-airflow that referenced this pull request Nov 23, 2018
Since the change of AIRFLOW-3203, the dockerpy client has upgraded
actually. Therefore, the requirements config should upgrade also to
avoid potentially misleading.
tmiller-msft pushed a commit to cse-airflow/incubator-airflow that referenced this pull request Nov 27, 2018
Since the change of AIRFLOW-3203, the dockerpy client has upgraded
actually. Therefore, the requirements config should upgrade also to
avoid potentially misleading.
elizabethhalper pushed a commit to cse-airflow/incubator-airflow that referenced this pull request Dec 7, 2018
Since the change of AIRFLOW-3203, the dockerpy client has upgraded
actually. Therefore, the requirements config should upgrade also to
avoid potentially misleading.
aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
Since the change of AIRFLOW-3203, the dockerpy client has upgraded
actually. Therefore, the requirements config should upgrade also to
avoid potentially misleading.
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Jan 23, 2019
Since the change of AIRFLOW-3203, the dockerpy client has upgraded
actually. Therefore, the requirements config should upgrade also to
avoid potentially misleading.
wmorris75 pushed a commit to modmed-external/incubator-airflow that referenced this pull request Jul 29, 2019
Since the change of AIRFLOW-3203, the dockerpy client has upgraded
actually. Therefore, the requirements config should upgrade also to
avoid potentially misleading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants