Skip to content

Conversation

@TJaniF
Copy link
Contributor

@TJaniF TJaniF commented Aug 9, 2024

Just a one character docs typo fix :)

EDIT: and a missing period.

@TJaniF TJaniF changed the base branch from main to v2-10-stable August 9, 2024 10:23
@TJaniF
Copy link
Contributor Author

TJaniF commented Aug 9, 2024

Just learned main is Airflow 3 now, will make a new PR for this before my gitting becomes even more embarrassing 👀 apologies to those who got pinged!

@TJaniF TJaniF closed this Aug 9, 2024
@ephraimbuddy
Copy link
Contributor

Just learned main is Airflow 3 now, will make a new PR for this before my gitting becomes even more embarrassing 👀 apologies to those who got pinged!

We can still backport fixes to Airflow v2-10-stable. A fix like this one can be backported, so it's not wrong to PR against main

@TJaniF
Copy link
Contributor Author

TJaniF commented Aug 9, 2024

Oh, thats good to know thank you! I wasn't sure how to not have all the other commits in here so now I branched off v2-10-stable and re-PRed :)

The solution probably would be for me to finally learn git 😅

@TJaniF TJaniF reopened this Aug 9, 2024
@TJaniF TJaniF changed the base branch from v2-10-stable to main August 9, 2024 16:07
@TJaniF
Copy link
Contributor Author

TJaniF commented Aug 9, 2024

@jedcunningham The same docs PR against main as requested :)

@eladkal
Copy link
Contributor

eladkal commented Aug 9, 2024

Seems the same as #41361 ?

@TJaniF
Copy link
Contributor Author

TJaniF commented Aug 9, 2024

Yes, @eladkal I did not see that @shahar1 had already taken care of it before reopening this, apologies. Will close for good now :)

@TJaniF TJaniF closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants