Fix Variable and KubernetesJobOperator Tests for Database Isolation Tests #41370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cret backend haven't called from EnvironmentVariablesBackend, Metastore and custom ones. This caused side effect to move the Variable.get() method to internal API
…cret backend haven't called from EnvironmentVariablesBackend, Metastore and custom ones
bugraoz93
requested review from
XD-DENG,
ashb,
dstandish,
kaxil and
potiuk
as code owners
boring-cyborg
bot
added
area:providers
area:secrets
provider:cncf-kubernetes
bugraoz93
changed the title
bugraoz93
commented
Aug 10, 2024
… definition of session for secret_backend.get_variable()
… definition of session for secret_backend.get_variable()
…cache invalidated in eac Variable.set() call
…dom tests in the lowest-dependency
potiuk
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #41067
Fixing remaining Variable tests for db isolation mode or skipping the ones which aren't working with internal_api.
It also includes a small fix for KubernetesJobOperator tests, I forgot to pass the session in the previous fix.
Edit:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.