-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Enable EksPodOperator when deferrable is true #41380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
#41377 was closed because branch was renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are waiting before actually executing the task? Also, you need to check wait_for_completion, if wait_for_completion is False you do not want to wait. wait_for_completion configures whether the operator wait for a given status, deferrable configures how to wait (if wait_for_completion is True): in poke mode or deferrable mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for review. I'm still getting familiar with deferrable concept and will work on resolving the issue as I understand it better.
I'll proceed accordingly, and mention if I need any help!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks for doing it :)
112d9d3 to
e12f135
Compare
|
I was under the impression this was already fixed by #41178 and the deferrable logic was inherited through the k8s pod operator itself. Were you testing with an older version of the provider packages? |
|
@o-nikolas you're right.
|
In particular reference to this:
What exactly is still broken? Can you describe that more, it would help me provide further direction. Thanks for sticking with this! |
e12f135 to
e8b8821
Compare
e8b8821 to
02b254f
Compare
|
Sorry for late reply! 🥲
The issue is no longer reproducible.
and, look at full logs in Anything else #39695 I’d like to dig deeper into the problem and request more information from the reporter (such as the full log when |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
(TBD) closes: #39685