Skip to content

Conversation

@jx2lee
Copy link
Contributor

@jx2lee jx2lee commented Aug 11, 2024

(TBD) closes: #39685

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Aug 11, 2024
@jx2lee
Copy link
Contributor Author

jx2lee commented Aug 11, 2024

#41377 was closed because branch was renamed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are waiting before actually executing the task? Also, you need to check wait_for_completion, if wait_for_completion is False you do not want to wait. wait_for_completion configures whether the operator wait for a given status, deferrable configures how to wait (if wait_for_completion is True): in poke mode or deferrable mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review. I'm still getting familiar with deferrable concept and will work on resolving the issue as I understand it better.
I'll proceed accordingly, and mention if I need any help!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for doing it :)

@jx2lee jx2lee marked this pull request as ready for review August 19, 2024 11:33
@jx2lee jx2lee marked this pull request as draft August 19, 2024 11:33
@jx2lee jx2lee force-pushed the fixed-ekspodoperator-deferrable branch from 112d9d3 to e12f135 Compare August 19, 2024 13:59
@o-nikolas
Copy link
Contributor

I was under the impression this was already fixed by #41178 and the deferrable logic was inherited through the k8s pod operator itself. Were you testing with an older version of the provider packages?

@jx2lee
Copy link
Contributor Author

jx2lee commented Aug 23, 2024

@o-nikolas you're right.

  • Deferrable logic was inherited throught the k8s pod operator. (execute in eks.py EksPodOperator)
  • It seems that issue in this PR was resolved by the fix in #41178 . The direction to address the issue was incorrect. I have two options: either close the issue or update the relevant test code in #39685. What do you think?

@o-nikolas
Copy link
Contributor

@o-nikolas you're right.

* Deferrable logic was inherited through the k8s pod operator. ([execute](https://github.com/apache/airflow/blob/c0ffa9c5d96625c68ded9562632674ed366b5eb3/airflow/providers/amazon/aws/operators/eks.py#L1075) in eks.py EksPodOperator)

* It seems that issue in this PR was resolved by the fix in [#41178](https://github.com/apache/airflow/pull/41178) . The direction to address the issue was incorrect. I have two options: either close the issue or update the relevant test code in [#39685](https://github.com/apache/airflow/issues/39685). What do you think?

In particular reference to this:

I have two options: either close the issue or update the relevant test code in #39685. What do you think?

What exactly is still broken? Can you describe that more, it would help me provide further direction. Thanks for sticking with this!

@jx2lee jx2lee force-pushed the fixed-ekspodoperator-deferrable branch from e12f135 to e8b8821 Compare August 28, 2024 14:52
@jx2lee jx2lee force-pushed the fixed-ekspodoperator-deferrable branch from e8b8821 to 02b254f Compare September 5, 2024 13:45
@jx2lee
Copy link
Contributor Author

jx2lee commented Sep 5, 2024

Sorry for late reply! 🥲

What exactly is still broken? Can you describe that more, it would help me provide further direction. Thanks for sticking with this!

The issue is no longer reproducible. EksPodOperator created with the deferrable parameter runs without any problems. Initially, I thought issue was due to it not being deferrable, but that was my mistake.

and, look at full logs in Anything else #39695
kubernetes.config.config_exception.ConfigException: Invalid kube-config file. No configuration found. often occurred. i think that kube config file in created pod was broken, because It could be related to network issue or others. I don’t think fix in #41178 resolved #39695.
-> Please let me know if I’m mistaken.

I’d like to dig deeper into the problem and request more information from the reporter (such as the full log when deferrable=False, etc).

@jx2lee jx2lee changed the title Enable EksPodOperator deferrable Enable EksPodOperator when deferrable is true Sep 7, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 23, 2024
@github-actions github-actions bot closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EksPodOperator error with deferrable=True

3 participants