Add comment on methodtools in mssql provider.yaml #41402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Aug 12, 2024
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Yeah - no strong feelings about that one - it could easily stay in as well. But yes. We cn remove it (effectively when provider min version will be >= 2.10).
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 18, 2024
When running tests for providers with old Airflow versions, we have to make sure to uninstall all packages before installing old Airflow versions - because some of the packages can be installed by new Airflow version and they are missing in the old Airflow version. This has already happened in apache#41402 with methodtools. This PR adds `--clean-airflow-installation` flag to relevant breeze commands that install other airflow version. This is quite a bit slower as it requires to uninstall and reinstall packages so we do not set it by default.
potiuk
added a commit
that referenced
this pull request
Aug 18, 2024
…41488) When running tests for providers with old Airflow versions, we have to make sure to uninstall all packages before installing old Airflow versions - because some of the packages can be installed by new Airflow version and they are missing in the old Airflow version. This has already happened in #41402 with methodtools. This PR adds `--clean-airflow-installation` flag to relevant breeze commands that install other airflow version. This is quite a bit slower as it requires to uninstall and reinstall packages so we do not set it by default.
Artuz37
pushed a commit
to Artuz37/airflow
that referenced
this pull request
Aug 19, 2024
…pache#41488) When running tests for providers with old Airflow versions, we have to make sure to uninstall all packages before installing old Airflow versions - because some of the packages can be installed by new Airflow version and they are missing in the old Airflow version. This has already happened in apache#41402 with methodtools. This PR adds `--clean-airflow-installation` flag to relevant breeze commands that install other airflow version. This is quite a bit slower as it requires to uninstall and reinstall packages so we do not set it by default.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Aug 20, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Aug 20, 2024
…pache#41488) When running tests for providers with old Airflow versions, we have to make sure to uninstall all packages before installing old Airflow versions - because some of the packages can be installed by new Airflow version and they are missing in the old Airflow version. This has already happened in apache#41402 with methodtools. This PR adds `--clean-airflow-installation` flag to relevant breeze commands that install other airflow version. This is quite a bit slower as it requires to uninstall and reinstall packages so we do not set it by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup on #41392