Remove deprecated code is AWS provider #41407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
force-pushed
the
vincbeck/aws_cleanup
branch
from
8056c3d to
15a13cb
Compare
ferruzzi
approved these changes
Aug 14, 2024
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
LGTM. Tons of small changes, but I love seeing old code dropped. The unit in particular look so much better now!
o-nikolas
approved these changes
Aug 14, 2024
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
Tests still aren't passing but in spirit the changes look good once things are passsing
eladkal
approved these changes
Aug 15, 2024
Artuz37
pushed a commit
to Artuz37/airflow
that referenced
this pull request
Aug 19, 2024
43 tasks
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Min Airflow version in providers moved to 2.8.0 in #41396. Some backward compatibility code in the Amazon provider package is only if the Airflow version is 2.7.1. Therefore, we can do some cleanup.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.